feat(git): Omit git info when git isnt installed #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheKevJames
requested changes
Sep 28, 2018
coveralls/git.py
Outdated
| @@ -94,7 +94,8 @@ def git_info(): | |||
| }] | |||
| if not all(head.values()): | |||
| log.warning('Failed collecting git data. Are you running ' | |||
| 'coveralls inside a git repository?', exc_info=ex) | |||
| 'coveralls inside a git repository? Is git installed?', | |||
| exc_info=True) | |||
There was a problem hiding this comment.
Huh, TIL you can pass in True instead of the exception instance. Looks like this causes an extra call to sys.exc_info though, which is needless when we could just use the already-captured ex from above. Could you revert that part of your change?
There was a problem hiding this comment.
I find it cleaner this way, but sure. Will push a commit in a few minutes!
Addresses this comment: TheKevJames#174 (comment) Previously, git info was omitted if git was installed but the .git directory was missing. This fix will also omit git info in case git itself is missing (unless, of course, the environment args are there).
|
@TheKevJames rebased and reverted the |
|
@nirizr nope, looks great. Thanks again for the fix! |
TheKevJames
approved these changes
Sep 28, 2018
|
(@nirizr oh, and a heads up that this will be released with 1.5.1, which I'm just pushing now) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses this comment: #174 (comment)
Previously, git info was omitted if git was installed but the .git directory was missing.
This fix will also omit git info in case git itself is missing (unless, of course, the environment args are there).