Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SemaphoreCI support #193

Merged
merged 1 commit into from
Feb 18, 2019
Merged

SemaphoreCI support #193

merged 1 commit into from
Feb 18, 2019

Conversation

slowr
Copy link
Contributor

@slowr slowr commented Feb 16, 2019

Added support for SemaphoreCI by parsing corresponding environment variables.

To avoid pylint failure:

R:103, 4: Too many return statements (7/6) (too-many-return-statements)

I changed the behavior of load_config_from_ci_environment to return only once in the end.

@slowr
Copy link
Contributor Author

slowr commented Feb 17, 2019

To address the failed checks:

  • Coveralls reporting a coverage decrease refers to a file that I have not changed
  • Travis-ci failures seem to happen randomly

@TheKevJames
Copy link
Owner

Thanks for the contribution! Looks good to me. Sorry about the CI issues, looks like a bit of weirdness on the Coveralls API side of things.

@TheKevJames TheKevJames merged commit 4e09918 into TheKevJames:master Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants