feat(api): support pull requests on buildkite #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://buildkite.com/docs/pipelines/environment-variables says that the pull request is available via BUILDKITE_PULL_REQUEST, which is either the number for a pull request, or "false" for a non-pull-request.
|
I don't think that check failure is related to my changes? |
|
@huonw thanks for the contribution, this looks great! Sorry about the linting failure, that indeed has nothing to do with your work. WIll fix separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://buildkite.com/docs/pipelines/environment-variables says that
the pull request is available via BUILDKITE_PULL_REQUEST, which is
either the number for a pull request, or "false" for a
non-pull-request.