Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(github): send null job_id to fix 422 during resubmission #269

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

vchrombie
Copy link
Contributor

If a submission is failed, the tool will check and adjust/resubmit again with a newly generated job_id. For GitHub Actions, this needs to be null again.

#252 (comment)

If a submission is failed, the tool will check and adjust/resubmit
again with a newly generated job_id. For GitHub Actions, this needs
to be null again.
Copy link
Owner

@TheKevJames TheKevJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch

@TheKevJames TheKevJames merged commit 54be754 into TheKevJames:master Mar 2, 2021
@TheKevJames
Copy link
Owner

Thanks for the fix!

@vchrombie
Copy link
Contributor Author

Thanks for the merge @TheKevJames, I hope the actions work fine now. 🤞

andy-maier pushed a commit to andy-maier/coveralls-python that referenced this pull request Dec 23, 2022
…ames#269)

If a submission is failed, the tool will check and adjust/resubmit
again with a newly generated job_id. For GitHub Actions, this needs
to be null again.
@vchrombie vchrombie deleted the 422-attempt-gha branch September 13, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants