Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to 1.21 #4

Merged
merged 3 commits into from
Jun 28, 2024
Merged

Update to 1.21 #4

merged 3 commits into from
Jun 28, 2024

Conversation

Tatnux
Copy link
Contributor

@Tatnux Tatnux commented Jun 28, 2024 •
edited
Loading

Entity.getAddEntityPacket() needs a TrackedEntity since 1.21, the easiest way to fix it is to create the packet manualy.

NonSwag
NonSwag requested changes Jun 28, 2024
View reviewed changes
Copy link
Member

@NonSwag NonSwag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, only one small thing, please take a look at the comment.

plugin/src/main/java/net/thenextlvl/hologram/implementation/CraftHologramLoader.java Outdated Show resolved Hide resolved
@NonSwag
Copy link
Member

NonSwag commented Jun 28, 2024

LGTM

@NonSwag NonSwag merged commit 5ccf5f9 into TheNextLvl-net:master Jun 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NonSwag NonSwag NonSwag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tatnux @NonSwag