Added area grouping #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the interface to better represent areas bound to multiple regions instead of just intersections. Updated import statements and documentation to reflect this change.
Introduced a `GroupedRegion` class to manage multiple `Region` objects collectively. This class supports basic operations like adding, removing, and querying regions, along with overriding several methods from the `AbstractRegion` class for more tailored functionality.
Renamed IntersectionAreaAdapter to GroupedAreaAdapter for better clarity and updated the associated implementation. This change ensures the naming reflects the functionality more accurately, improving code maintainability.
Replaced CraftIntersectionArea with CraftGroupedArea to better reflect its purpose in managing grouped regions. This includes updating relevant imports and class specifics to the new GroupedRegion type.
Removed the dependency on RegionIntersection and replaced it with GroupedRegion in areaService. This change updates the wrapper registration to use the corresponding CraftGroupedArea class.
Eliminated the unused `TypesAreNotNullByDefault` annotation import to clean up the code. This helps to reduce clutter and improves code readability.
Introduced a new command class `AreaGroupCommand`, enabling the creation, addition, inspection, and removal of grouped areas. This facilitates better management of regionized and grouped areas within the plugin, with appropriate permission checks for each action.
Removed `net.thenextlvl.core:annotations:2.0.1` from the dependencies in `plugin/build.gradle.kts` as it is no longer needed. This clean-up helps streamline the build process and avoids unnecessary inclusion of unused libraries.
This commit deletes the NamePattern annotation file and several package-info.java files. Additionally, it updates method signatures to include @NotNull annotations for better null safety.
Upgraded the versions of 'net.thenextlvl.core' dependencies in both 'plugin' and 'api' modules. This change ensures the use of the latest features and improvements provided by the updated libraries.
Update method calls for registering type hierarchy adapters to use simplified methods in `LocationAdapter` and `KeyAdapter`. This improves consistency and readability in the `CraftAreaProvider` class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.