Reduce repeated translation codes. #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
@ungjinPark This probably needs some sync as well |
|
@ferllings I just merged it. but need more enough test. I checked there was no problem with the naked eye. but not tested with screen readers |
|
Any updates? The preferences.html file still have merge issues. |
|
@ferllings I've certainly checked and merged codes but I don't know why merging issues are there. I'm on checking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think existing codes is too repeated. querySelector is too many used unnecesserily.
And, Too long CSS selector has used in querySelector. It is not worng code, but we can use more shorter selector than now.
modified next files
What's changed?
In html, I gave Id or class attributes at some container to make easier to access from DOM.
In js, I replaced repeated some DOM codes to 'NodeList.forEach' code patterns, and It's work correctly.
and simplified some selectors.
Please review the above files.