Fix incorrect modified state in custom list editor following save. (#52)

CHANGELOG.md

@@ -1,5 +1,11 @@
 ## Changelog
 
+### v0.4.1
+
+#### Fixed
+
+- After an auto updating list is saved, the list status is now correctly updated, and the Save button is now correctly disabled.
+
 ### v0.4.0
 
 #### Updated

src/reducers/__tests__/customListEditor-test.ts

@@ -393,6 +393,23 @@ describe("custom list editor reducer", () => {
       expect(nextState).to.equal(state);
     });
 
+    it("sets isSearchModified and isModified to false", () => {
+      const state = {
+        ...initialState,
+        id: 42,
+        isSearchModified: true,
+        isModified: true,
+      };
+
+      const nextState = reducer(state, {
+        type: `${ActionCreator.CUSTOM_LISTS}_${ActionCreator.LOAD}`,
+        data: listData,
+      });
+
+      expect(nextState.isSearchModified).to.equal(false);
+      expect(nextState.isModified).to.equal(false);
+    });
+
     context("when auto update is enabled", () => {
       it("defaults the autoUpdate property to true for a new list", () => {
         const state = {

src/reducers/customListEditor.ts

@@ -875,6 +875,8 @@ const initialStateForList = (
         draftState.searchParams.baseline.sort = order;
         draftState.searchParams.current.sort = order;
       }
+
+      draftState.isSearchModified = false;
     }
 
     draftState.error = error;
@@ -955,23 +957,22 @@ const handleCustomListEditorOpen = (
  *                       to the id of a list that is present in the data.
  * @returns      The next state
  */
-const handleCustomListsLoad = (
-  state: CustomListEditorState,
-  action
-): CustomListEditorState => {
-  if (action.isAfterShare) {
-    // If this is a reload of custom list data following a share operation, we can ignore the
-    // action. The sharing state will be updated by the handler for the CUSTOM_LIST_SHARE_SUCCESS
-    // action.
+const handleCustomListsLoad = validatedHandler(
+  (state: CustomListEditorState, action): CustomListEditorState => {
+    if (action.isAfterShare) {
+      // If this is a reload of custom list data following a share operation, we can ignore the
+      // action. The sharing state will be updated by the handler for the CUSTOM_LIST_SHARE_SUCCESS
+      // action.
 
-    return state;
-  }
+      return state;
+    }
 
-  const { id } = state;
-  const { data } = action;
+    const { id } = state;
+    const { data } = action;
 
-  return initialStateForList(id, data, state);
-};
+    return initialStateForList(id, data, state);
+  }
+);
 
 /**
  * Handle the CUSTOM_LIST_DETAILS_LOAD action. This action is fired when a call to the