Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use asset/resource type for SASS font support with WebPack 5. (PP-1513) #125

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Use asset/resource type for SASS font support with WebPack 5. (PP-1513) #125

merged 1 commit into from
Aug 16, 2024

Conversation

tdilauro
Copy link
Contributor

@tdilauro tdilauro commented Aug 15, 2024 •
edited by jira bot
Loading

Description

Fixes issues rendering Font Awesome fonts.

Motivation and Context

Fonts were not rendering.

[Jira PP-1513]

How Has This Been Tested?

  • Tested locally via dev-server against development server.
  • CI tests pass.

Checklist:

  • N/A - I have updated the documentation accordingly.
  • All new and existing tests passed.

@tdilauro tdilauro requested a review from ray-lee August 15, 2024 22:18
ray-lee
ray-lee approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@ray-lee ray-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@tdilauro tdilauro merged commit 1d224cc into main Aug 16, 2024
1 check passed
@tdilauro tdilauro deleted the bugfix/font-awesome-fonts-not-rendering branch August 16, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ray-lee ray-lee ray-lee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tdilauro @ray-lee