Add list filtering to lane editor. #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdilauro
approved these changes
Sep 30, 2022
| @@ -75,7 +118,12 @@ export default class LaneCustomListsEditor extends React.Component< | |||
| > | |||
| <GrabIcon /> | |||
There was a problem hiding this comment.
ll. 119-131 is duplicated below in ll. 188-200. Would it be useful to refactor?
There was a problem hiding this comment.
Good point. I extracted the duplicate code into its own function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds the ability to filter the lists that are shown when editing a lane. The options are to show only the lists owned by the current library (the default), only lists shared by other libraries, or all lists.
It also adds a share icon to lists that are owned by other libraries, to make them easy to differentiate.
Motivation and Context
This makes it easier for librarians to find their own lists, vs. lists shared by other libraries, when creating lanes.
Notion: https://www.notion.so/lyrasis/Add-filtering-options-to-lists-when-editing-a-lane-08b679fb44124a6aa9cd8743a003a43c
How Has This Been Tested?
In Available Lists, the Show menu should have "Owned" selected. Only the owned list should appear. The list shared by the first library should not appear.
The owned list should disappear, and the list shared by the first library should appear.
All the lists should appear. The list shared from the first library should have a share icon next to its name, and the owned list should not.
The list should disappear from the Available Lists list, and appear in the Lists in This Lane list.
The Available Lists list should remain empty, and the shared list should continue to appear in the Lists in This Lane list.
The shared list should appear in the Available Lists list, and disappear from the Lists in This Lane list.
Checklist: