Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use legacy key/value format in Dockerfile. (PP-1718) #661

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Don't use legacy key/value format in Dockerfile. (PP-1718) #661

merged 1 commit into from
Sep 13, 2024

Conversation

tdilauro
Copy link
Collaborator

@tdilauro tdilauro commented Sep 13, 2024 •
edited by jira bot
Loading

Description

  • Update Dockerfile to replace legacy "... key value" syntax with new key=value format.

Motivation and Context

[Jira PP-1718]

How Has This Been Tested?

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@tdilauro tdilauro requested a review from a team September 13, 2024 14:22
jonathangreen
jonathangreen approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@jonathangreen jonathangreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@tdilauro tdilauro merged commit 6c032df into main Sep 13, 2024
9 checks passed
@tdilauro tdilauro deleted the chore/update-dockerfile-env-vars branch September 13, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathangreen jonathangreen jonathangreen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tdilauro @jonathangreen