Fix bug where open access titles in ODL feeds would fail to import (PP-847) #147
Conversation
| @@ -1,5 +1,5 @@ | |||
| [build-system] | |||
| build-backend = "poetry.masonry.api" | |||
| build-backend = "poetry.core.masonry.api" | |||
There was a problem hiding this comment.
This seems like its been incorrect for some time, and its not usually a problem, since its not normally used. But I was installing the package in development mode for testing, which was failing because this was not correctly set.
Poetry documentation about what the value should be:
https://python-poetry.org/docs/pyproject/#poetry-and-pep-517
There was a problem hiding this comment.
Yeah, I looked this up and saw that it changed between 1.3 and 1.4. 🤷🏽♂️
|
@tdilauro FYI if your reviewing this, I just noticed I updated the wrong test description. Just pushed a commit to fix that. |
| @@ -186,6 +186,38 @@ class ODLSemanticAnalyzerTest(AnalyzerTest): | |||
| ) | |||
| ], | |||
| ), | |||
| ( | |||
| "when_publication_does_not_contain_neither_licenses_nor_oa_link", | |||
There was a problem hiding this comment.
Minor: We might be a double negative in this label, which is confusing:
"when_publication_does_not_contain_neither_licenses_nor_oa_link" ->
"when_publication_contains_neither_licenses_nor_oa_link"
or
"when_publication_has_no_licenses_or_oa_links"
We should be supporting this case, but there was a bug in the parser preventing it. The fix is one line, but I also added a test to make sure we are handling this case.