V2.x 4729 merge v1.x #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4698 new method for generating payment confirmation
joseftraxler
approved these changes
Jul 31, 2023
src/Service/ApiServiceInterface.php
Outdated
| * | ||
| * @throws ApiException if payment is not paid yet | ||
| */ | ||
| public function generatePaymentConfirmationPdf(Identifier $uid, LanguageCode $languageCode = null); |
There was a problem hiding this comment.
I recommend using of return types in 2.x vesion as much as you can.
There was a problem hiding this comment.
As well as parameters.
|
@AlexKratky promin za spam notifikace, myslel jsem ve stylu automatu a zapomel ze mas dovcu. |
Triplkrypl
force-pushed
the
v2.x-4729-merge-v1.x
branch
from
5f84abd
to
8764a11
Compare
Triplkrypl
force-pushed
the
v2.x-4729-merge-v1.x
branch
from
8764a11
to
78e018a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://redmine.havelholding.cz/issues/4729
Basically same change as: #52, with resolved merge conflict and updates logic using PSR HTTP client and new version of phpunit.