Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nullable pay and state url #63

Merged

Conversation

AlexKratky
Copy link
Member

https://redmine.havelholding.cz/issues/4949

Not sure if this is considered as Breking change. Developers should not use this on subscription payments, but I guess someone 100% does not check if payment is subscription or not :D

@Triplkrypl
Copy link
Member

Not sure if this is considered as Breking change.

This is break change, if any one expect only string in return type, and we add null, somewhere can app crash on incompatible type.
@tymajiri will we try make another solution without break changes, or we hope than other developers or ThePay clients will be merciful to us, if we will fucked up some integration?

@tymajiri
Copy link
Contributor

Not sure if this is considered as Breking change.

This is break change, if any one expect only string in return type, and we add null, somewhere can app crash on incompatible type. @tymajiri will we try make another solution without break changes, or we hope than other developers or ThePay clients will be merciful to us, if we will fucked up some integration?

Leda že bychom předávali prázdný string, ale to si nejsem jist zda je lepší 🤨

@AlexKratky AlexKratky merged commit b0c8243 into v2.x Jan 4, 2024
6 checks passed
@AlexKratky AlexKratky deleted the 4949-subscription-payment-pay-and-state-url-removed branch January 4, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants