-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the argument --depth 1 to git clone for some tools missing it #178
Conversation
@QU35T-code commented on my review in #177 and said that CME is a special case preventing the --depth 1 flag. I better understand the user experience issue this change would introduce after reading https://medium.com/@thriving_chiffon_gnu_714/exploring-git-clone-depth-828eb4bac6c4 As a consequence, I'll revert the change for CME, and will add a comment above the clone line to explain why --depth 1 cannot be added here. Is there any other tool covered by this exception ? |
I think there's been some confusion or misunderstanding. Git must be present to allow them to do git pulls if needed, but as long as depth 1 doesn't block this operation, it should be fine. For operations that can generate errors and harm the user experience, why not think about adding quick fix methods to the exegol documentation to easily unshallow the repository (for example). |
Yes sorry @gbe, actually it won't cause any issues, you can add it ! |
No worries @QU35T-code. In that case, I leave the PR as it is for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's run the workflow to see if there is a problem with tools
Looks like the commit to remove a single line comment broke the CI/CD. |
Not your fault, the error is raised because another tool (DonPAPI) had an update and the installation function no longer working, this error is not related to your changes. |
However, your PR have some conflict with the official branch, can you merge the official merge in yours to fix the conflict ? Thank you |
New commit. |
After reviewing the PR #177, I noticed that the argument --depth 1 was missing when cloning CrackMapExec.
Turns out, there were other tools missing it (command below was run against the
dev
branch):To avoid any merge conflict, this PR must be merged after #177.
Indeed, I reproduced in this PR some of the changes brought by #177 and I added the modification to the comment I suggested.