Add the argument --depth 1 to git clone for some tools missing it

[gbe]

After reviewing the PR #177, I noticed that the argument --depth 1 was missing when cloning CrackMapExec.

Turns out, there were other tools missing it (command below was run against the dev branch):

grep -rn clone * 2> /dev/null | grep git | grep -v depth | wc -l
20

To avoid any merge conflict, this PR must be merged after #177.
Indeed, I reproduced in this PR some of the changes brought by #177 and I added the modification to the comment I suggested.

[gbe]

@QU35T-code commented on my review in #177 and said that CME is a special case preventing the --depth 1 flag.

I better understand the user experience issue this change would introduce after reading https://medium.com/@thriving_chiffon_gnu_714/exploring-git-clone-depth-828eb4bac6c4

As a consequence, I'll revert the change for CME, and will add a comment above the clone line to explain why --depth 1 cannot be added here.

Is there any other tool covered by this exception ?

[Dramelac]

@QU35T-code commented on my review in #177 and said that CME is a special case preventing the --depth 1 flag.

I think there's been some confusion or misunderstanding.
There's no particular reason not to do depth 1 on CME.

Git must be present to allow them to do git pulls if needed, but as long as depth 1 doesn't block this operation, it should be fine.

For operations that can generate errors and harm the user experience, why not think about adding quick fix methods to the exegol documentation to easily unshallow the repository (for example).

[QU35T-code]

Yes sorry @gbe, actually it won't cause any issues, you can add it !

[gbe]

No worries @QU35T-code.

In that case, I leave the PR as it is for review.

[QU35T-code]

Let's run the workflow to see if there is a problem with tools

[gbe]

Looks like the commit to remove a single line comment broke the CI/CD.
Is there something I can do to solve this?

[Dramelac]

Looks like the commit to remove a single line comment broke the CI/CD. Is there something I can do to solve this?

Not your fault, the error is raised because another tool (DonPAPI) had an update and the installation function no longer working, this error is not related to your changes.

[Dramelac]

However, your PR have some conflict with the official branch, can you merge the official merge in yours to fix the conflict ?

Thank you

[gbe]

New commit.
It should merge fine now.