Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pipx to install DonPAPI after they moved to pyproject.toml #184

Merged
merged 4 commits into from
Jul 6, 2023

Conversation

spameier
Copy link
Contributor

@spameier spameier commented Jul 6, 2023

(reopening of #183, because I deleted the branch)

Description

DonPAPI is now a proper Python package using pyproject.toml. Therefore the installation through requirements.txt fails.

@QU35T-code QU35T-code added enhancement New feature or request waiting for additional changes Further changes are requested labels Jul 6, 2023
@spameier
Copy link
Contributor Author

spameier commented Jul 6, 2023

I just noticed that the description Python network and web application scanner is also wrong. Should I change that?

Copy link
Member

@Dramelac Dramelac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to update the history of DonPAPI (sources/assets/zsh/history.d/donpapi) because the command name changed from DonPAPI.py to DonPAPI.
You can add other command history of donPAPI if you want but its not mandatory.

@Dramelac
Copy link
Member

Dramelac commented Jul 6, 2023

(and no need to force push, you can add commit so we can follow your changes)

@spameier spameier requested a review from Dramelac July 6, 2023 12:35
@QU35T-code QU35T-code removed the waiting for additional changes Further changes are requested label Jul 6, 2023
@Dramelac
Copy link
Member

Dramelac commented Jul 6, 2023

Will be merged as soon as the workflow end, thank you for the PR @spameier !

@Dramelac Dramelac changed the title (fix) use pipx to install DonPAPI after they moved to pyproject.toml Use pipx to install DonPAPI after they moved to pyproject.toml Jul 6, 2023
@Dramelac Dramelac merged commit 45b7d36 into ThePorgs:dev Jul 6, 2023
@ShutdownRepo ShutdownRepo mentioned this pull request Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants