-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add mobsf to mobile packages #186
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR.
I quickly tested on ARM
and the installation failed because of dependencies. Have you been able to verify that it installs correctly on amd ?
It works for AMD on my VM. What error do you see? |
On ARM : root@exegol-test2 /workspace # python3 -m pipx install /opt/tools/Mobile-Security-Framework-MobSF/
Fatal error from pip prevented installation. Full pip output in file:
/root/.local/pipx/logs/cmd_2023-09-05_14.49.13_pip_errors.log
pip seemed to fail to build package:
yara-python-dex>=1.0.1
Some possibly relevant errors from pip install:
error: subprocess-exited-with-error
FileNotFoundError: [Errno 2] No such file or directory: 'yara-python/README.rst'
error: metadata-generation-failed
Error installing mobsf from spec '/opt/tools/Mobile-Security-Framework-MobSF'. |
When I have time, I'll try to fix the problem on the ARM side (https://github.com/MobSF/yara-python-dex) |
Putting PR on hold while #216 isn't merged |
5cc8908
to
e8bbd76
Compare
ARM build still fails 😿:
|
Could be fixed with python3 -m pip install git+https://github.com/MobSF/yara-python-dex.git Install should then succeed on both archs with the following code function install_mobsf(){
# CODE-CHECK-WHITELIST=add-aliases
colorecho "Installing Mobile Security Framework"
fapt wkhtmltopdf
git -C /opt/tools clone --depth 1 https://github.com/MobSF/Mobile-Security-Framework-MobSF MobSF
cd /opt/tools/MobSF || exit
python3 -m venv ./venv
# "./venv/bin/python3 -m pip install yara-python-dex" doesn't work in ARM64
./venv/bin/python3 -m pip install git+https://github.com/MobSF/yara-python-dex.git
./venv/bin/python3 -m pip install .
add-history mobsf
add-test-command "./venvs/mobsf/bin/python -c 'from mobsf.MobSF.settings import VERSION; print(VERSION)'"
add-to-list "mobsf,https://github.com/MobSF/Mobile-Security-Framework-MobSF,Automated and all-in-one mobile application (Android/iOS/Windows) pen-testing malware analysis and security assessment framework"
} The problem here is that all MobSF binaries would be installed in
Converting PR to draft while there's still major work to be done on it |
This will be supported in the next release of pipx through |
7053a37
to
39fd1df
Compare
Let's run the pipeline and merge if we get the green lights, thank you @spameier 👍 |
Description
Adds MobSF to packages for mobile apps.