Reduce Docker layers #187
Merged
Reduce Docker layers #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
QU35T-code
approved these changes
Jul 20, 2023
Dramelac
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
Waiting for the result of the pipeline & test but seems good to me, thank you @gbe for this update !
For your information, someone is already working with a multi-stage build approach for the exegol image. So we can merge the layers for now but we will have to split them again later when this next approach will be ready.
QU35T-code
added
the
ready for merge
Closed
ShutdownRepo
removed
the
ready for merge
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1/ As mentionned in #96, this PR aims at reducing the number of layers of the Docker images for better performance, reduced image size and to remove potential caching quirks. To do so, the RUN calls are merged into one as recommended by Docker best practices.
For example, the released image full-3.0.2 has 28 layers. By reducing it to 4 layers, the new image is 0.9GB smaller.
2/ In addition, the image is based from
debian:11-slimrather thandebian:11. Any extra necessary packages to build the image will be pulled from Debian's repositories anyway.3/ Finally, the apt cache files are removed from the image. There is no need to ship an image with outdated package lists.