-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove zsh color for comments #211
Conversation
Nice, could you maybe set the style to something grey and italic, or only grey ? |
Unfortunately, grey is not a supported color apparently. There are only 8 from what I understand: https://github.com/zsh-users/zsh/blob/master/Functions/Misc/colors When the attribute is none and the background is black (as in my example), the comment appears in white. Should the background be white, the comment turns black automatically. This is nice for crazy people with a white background ;) However, if we set the color amongst the 8 possible ones, it seems the best ones are (in my opinion and in order of preference) :
The others colors may be too much connotated as an error (red), a success (green), pown (yellow). Plus, these three catch too much the eye for a text that is only a comment, and by definition not important. Aaah, taste and colors 😄 |
Alright, let's go with cyan then |
@ShutdownRepo Thanks for your return. This is done. |
@gbe I was able to have grey comments with the following line, I'm editing your PR now ZSH_HIGHLIGHT_STYLES[comment]='fg=#888888' Let's have it that way so that the format is similar to what's been set on |
Setting the comment color to grey
Perfect |
Tests passed, merging now |
Description
Whenever I am in the middle of a command line and I find out that I am missing a piece, I like commenting the line, to easily come back to it later.
However, the way zsh currently behaves completely hides the command as it is basically black on black.
The image below shows how "This is a comment" is displayed (hint: it's written on the first line):
This PR makes the same comment appear as follows:
At least we can read something.
This PR is minor and is a customization I have in my-resources, I thought maybe it can be of interest of others.
PR is based on the branch 3.1.1.