Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the tool RustScan #228

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Add the tool RustScan #228

merged 1 commit into from
Sep 7, 2023

Conversation

gbe
Copy link
Contributor

@gbe gbe commented Sep 6, 2023

Hello,

this PR aims at adding the tool RustScan to the base image.
I was not sure about the sourcing, but I left it as is.
This code is actually inspired from the function install_rusthound.

Cheers

Copy link
Member

@QU35T-code QU35T-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @gbe, better to move this tool to the network package, like nmap i think

@QU35T-code QU35T-code added waiting for additional changes Further changes are requested new tool(s) This adds one or multiple tools to Exegol labels Sep 6, 2023
@gbe
Copy link
Contributor Author

gbe commented Sep 6, 2023

Done. I squashed the commits.

@QU35T-code
Copy link
Member

I launched the test workflow

@QU35T-code QU35T-code removed the waiting for additional changes Further changes are requested label Sep 6, 2023
@QU35T-code
Copy link
Member

Network failed 2023-09-06T21:44:08.0637528Z #36 247.8 fatal: unable to access 'https://github.com/radareorg/vector35-arch-armv7/': Failed to connect to github.com port 443: Connection timed out but the installation works. We can merge.

@QU35T-code QU35T-code added the ready for merge in the waitlist for merge, requires preliminary steps label Sep 6, 2023
Comment on lines 1 to 4
rustscan -a "$CIDR" --scripts custom --ulimit 5000
rustscan -a "$CIDR" --greppable
rustscan -a "$CIDR" -p 80,443,8080
rustscan -a "$CIDR" --top
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use long format option

  • --addresses instead of -a
  • --ports instead of -p
    Also please replace $CIDR with $TARGET (there is a set of defined arguments to be used dynamically in the history)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is done. Commits squashed.

@ShutdownRepo ShutdownRepo added waiting for additional changes Further changes are requested and removed ready for merge in the waitlist for merge, requires preliminary steps labels Sep 7, 2023
@QU35T-code QU35T-code added ready for merge in the waitlist for merge, requires preliminary steps and removed waiting for additional changes Further changes are requested labels Sep 7, 2023
@ShutdownRepo
Copy link
Member

LGTM

@ShutdownRepo ShutdownRepo removed the ready for merge in the waitlist for merge, requires preliminary steps label Sep 7, 2023
@ShutdownRepo ShutdownRepo merged commit 1a589ec into ThePorgs:dev Sep 7, 2023
@gbe gbe deleted the add-rustscan branch September 7, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new tool(s) This adds one or multiple tools to Exegol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants