Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempting to fix random network issues when building #238

Merged
merged 12 commits into from
Sep 14, 2023

Conversation

ShutdownRepo
Copy link
Member

During a build, some commands sometimes fetch things online (e.g. curl, wget, apt, git, go, git, etc.).
If a random network issue occurs and makes that commands fail, the whole build will be discarded as one tool will fail unit test.
In order to counter that, those commands will be retried every X seconds, X being exponentially bigger after each retry.

@ShutdownRepo ShutdownRepo added the enhancement New feature or request label Sep 13, 2023
@ShutdownRepo ShutdownRepo self-assigned this Sep 13, 2023
@ShutdownRepo
Copy link
Member Author

I think we're good to go like this, good enough for dev branch
builds are failing because of a proxmark issue right now (RfidResearchGroup/proxmark3#2113)

@ShutdownRepo ShutdownRepo added the ready for merge in the waitlist for merge, requires preliminary steps label Sep 14, 2023
@ShutdownRepo ShutdownRepo merged commit a581bb1 into dev Sep 14, 2023
39 of 41 checks passed
@ShutdownRepo ShutdownRepo removed the ready for merge in the waitlist for merge, requires preliminary steps label Sep 14, 2023
@ShutdownRepo ShutdownRepo deleted the fix/install-timeouts branch September 14, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant