Updated firefox addon installer #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d with addons that does not use manifest.json to store their id.
There was a problem hiding this comment.
Putting this PR on hold for now, as #245 could probably initiate some conflicts
Also, we need to understand why you needed the changes you made in load_supported_setups.sh, I feel like it should work without...
There was a problem hiding this comment.
I don't understand why those changes would be needed as both bash's bashrc includes the pyenv setup since 331c39f, we'll need to make a few tests to understand what be going wrong here
ShutdownRepo
added
on hold
gbe
reviewed
Sep 28, 2023
gbe
reviewed
Sep 28, 2023
gbe
reviewed
Sep 28, 2023
ShutdownRepo
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Patched issue where addon links were not parsed correctly.
Also added support for addons that do not contain their id in the manifest.json file.
Related issues
This patch is an answer to this post on the Discord server :
https://discord.com/channels/1031715284517662750/1037764873897127936/1154342645850710047