-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CyberChef #259
Add CyberChef #259
Conversation
I think it would be nice to have a bookmark indeed, otherwise this addition would remain unnoticed for a large base of users. |
Do you know how can I test my images repository ? Or should I let the CI / CD pipeline do the job ? |
Thank you @lap1nou for the PR, and thanks @gbe for initiating the review
Yes this is possible, you can build a local image with the wrapper. See the install doc. It should be something like
Agreed, but in my opinion, the bookmark should point to the online version, and not the local one. The local services will soon be listed in a specific section in the documentation. |
@ShutdownRepo Ok I'm gonna try to test the image, thank you. Hum don't you think we should only have the local version ?, it has the advantage of being more secure in case someone want to paste some hash in it for example. It's just an HTML file and some JS, it's not a complete web service. Now that I think of this, it should probably be placed in the |
Tools to be used in the container --> images In this case, the local version, on the images, seems relevant |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @lap1nou,
These dependencies are missing.
/usr/bin/open: 882: iceweasel: not found
/usr/bin/open: 882: seamonkey: not found
/usr/bin/open: 882: mozilla: not found
/usr/bin/open: 882: epiphany: not found
/usr/bin/open: 882: konqueror: not found
[1060262:1060262:1018/130213.777341:ERROR:zygote_host_impl_linux.cc(100)] Running as root without --no-sandbox is not supported. See https://crbug.com/638180.
/usr/bin/open: 882: chromium-browser: not found
/usr/bin/open: 882: google-chrome: not found
/usr/bin/open: 882: www-browser: not found
/usr/bin/open: 882: links2: not found
/usr/bin/open: 882: elinks: not found
/usr/bin/open: 882: links: not found
/usr/bin/open: 882: lynx: not found
/usr/bin/open: 882: w3m: not found
I wanted to add OCD mindmap (https://github.com/Orange-Cyberdefense/ocd-mindmaps) as a bookmark aswell, should I create another PR ? |
Yes, but on that specific addition, the best would be to create a "mindmaps" directory and have that one in it |
@lap1nou can you resolve conflicts ? |
Yup sorry mistype. Should be good now. |
Missing check whitelist code for aliases and history For exemple : https://github.com/ThePorgs/Exegol-images/blob/dev/sources/install/package_ad.sh#L7 |
you can chain them with a comma :
and it should be good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @ShutdownRepo, For the test function, this is strange:
Do you have an idea how to test for the presence of a file ? I saw that Exegol-images/sources/install/package_base.sh Line 112 in 0fa6ea0
For the installation this is really strange, I tried to use |
Weird indeed, let’s run the tests again |
Thank you @lap1nou for the pull request, thank you @QU35T-code and @gbe for the reviews ! |
Description
This PR will add a new bookmark for the tool . The tool can be used from the web, but a local version is available and is probably a better choice.
For the moment the PR just download and install the latest version of the tool, however if the change is accepted I can modifiy the Firefox SQLite DB to add the bookmark aswell.
Related issues
N / A
Point of attention
N / A