Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BloodHound customqueries: refacto for clarity, performance, fix and new queries #322

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

gbe
Copy link
Contributor

@gbe gbe commented Apr 2, 2024

This PR aims at improving the custom queries for Bloodhound.

To do so, I refactored many queries to:

  • standardize a bit more the formatting while reducing the queries length
  • improve the performance of queries by adding more criteria to reduce the set of nodes Neo4j must take into account when computing the results, the flag enabled is a typical example
  • remove useless subqueries
  • improve the regexp for the queries checking for plaintext password
  • fix a bogus request
  • one query was not doing what the comment said it would
  • add more indexes
  • add one nice query I wrote: Administrators and Domain/Entreprise Admins with sessions not on domain controllers

@gbe gbe changed the title BloodHound customqueries: refacto for clarity, performance, fix and n… BloodHound customqueries: refacto for clarity, performance, fix and new queries Apr 2, 2024
Copy link
Member

@ShutdownRepo ShutdownRepo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ShutdownRepo ShutdownRepo merged commit 128bd93 into ThePorgs:dev Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants