Bloodhound customqueries: better RDP queries #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbe
changed the title
ShutdownRepo
approved these changes
Apr 5, 2024
|
Thank you @gbe LGTM 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear team,
I noticed that when querying Bloodhound to get a list of machines where Domain users can RDP to, it only lists the machines where the single node "domain users" has a direct canRDP relationtype with the computer objects.
The existing query does not take into account that Domain Users can be member of a group, and it's this group that has a canRDP relationship with the computers.
This PR fixes that, and is basically the union of the builtin queries:
First Degree RDP PrivilegesandGroup Delegated RDP Privileges.In addition: