Reduce image size by removing sslscan build files #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QU35T-code
added
enhancement
QU35T-code
approved these changes
Apr 15, 2024
QU35T-code
added
help wanted
|
Awesome! What else is need in that PR? |
|
@ShutdownRepo, I think we can merge this one and open another to optimize the image size. |
ShutdownRepo
approved these changes
Apr 18, 2024
ShutdownRepo
removed
on hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
sslscan is built statically, so there is no need to keep in the image the files generated when building it.
Before the PR:
After the PR: