Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added '--run-as=root' for binwalk #347

Closed
wants to merge 2 commits into from

Conversation

lap1nou
Copy link
Contributor

@lap1nou lap1nou commented May 13, 2024

Description

Greetings,

This PR aims to supress the error message thrown by binwalk in case we don't specify that we want to run it as root using --run-as=root:

Extractor Exception: Binwalk extraction uses many third party utilities, which may not be secure. If you wish to have extraction utilities executed as the current user, use '--run-as=root' (binwalk itself must be run as root).
----------------------------------------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/binwalk/core/module.py", line 258, in __init__
    self.load()
  File "/usr/lib/python3/dist-packages/binwalk/modules/extractor.py", line 147, in load
    raise ModuleException("Binwalk extraction uses many third party utilities, which may not be secure. If you wish to have extraction utilities executed as the current user, use '--run-as=%s' (binwalk itself must be run as root)." % user_info.pw_name)
binwalk.core.exceptions.ModuleException: Binwalk extraction uses many third party utilities, which may not be secure. If you wish to have extraction utilities executed as the current user, use '--run-as=root' (binwalk itself must be run as root).
----------------------------------------------------------------------------------------------------

Related issues

N/A

Point of attention

While the binwalk warning is perfectly valid and make sense in a classical setup, I think in our case it doesn't really do much since we are running everything as root anyway. Correct me if I'm wrong though.

@ShutdownRepo ShutdownRepo self-assigned this May 14, 2024
@ShutdownRepo ShutdownRepo added the enhancement New feature or request label May 14, 2024
@ShutdownRepo ShutdownRepo added the on hold Item on hold. Requires another matter to be resolved first. label May 14, 2024
@ShutdownRepo
Copy link
Member

On hold, this PR is to be closed when its changes are imported in #348

@lap1nou lap1nou closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request on hold Item on hold. Requires another matter to be resolved first.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants