Adding Postman to Exegol #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Postman script
Add install script for Postman (including installation of libsecret-1-0, needing for Postman to work)
QU35T-code
added
under review
QU35T-code
requested changes
Jun 4, 2024
There was a problem hiding this comment.
Hello @Karmhack,
Thanks for this PR. Here are a few comments :
Change : - Postman to postman - apt to fapt - add "# CODE-CHECK-WHITELIST=add-aliases" - add arm install (not tested)
QU35T-code
reviewed
Jun 6, 2024
QU35T-code
reviewed
Jun 6, 2024
QU35T-code
requested changes
Jun 6, 2024
There was a problem hiding this comment.
@Karmhack - To avoid duplicate code between AMD and ARM installations, you can simply set a local variable with the name of the archive (linux_arm64 / linux_64) and perform the installation afterwards.
QU35T-code
approved these changes
Jun 7, 2024
QU35T-code
removed
the
waiting for additional changes
ShutdownRepo
approved these changes
Jun 8, 2024
QU35T-code
added
ready for merge
QU35T-code
removed
the
ready for merge
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description