Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smbclient-ng #352

Merged
merged 9 commits into from
Jun 8, 2024
Merged

Add smbclient-ng #352

merged 9 commits into from
Jun 8, 2024

Conversation

p0dalirius
Copy link
Contributor

Description

Added smbclient-ng into exegol

@QU35T-code QU35T-code changed the title Add smbclientng Add smbclient-ng Jun 3, 2024
@QU35T-code QU35T-code added new tool(s) This adds one or multiple tools to Exegol under review Time to think about the need / implementation labels Jun 3, 2024
@QU35T-code
Copy link
Member

Hey @p0dalirius,

Thx for this PR. Wouldn't you prefer your tool to be called smbclient-ng instead of smbclientng ?

sources/install/package_ad.sh Outdated Show resolved Hide resolved
sources/install/package_ad.sh Outdated Show resolved Hide resolved
@QU35T-code QU35T-code added the waiting for additional changes Further changes are requested label Jun 3, 2024
@QU35T-code QU35T-code self-assigned this Jun 3, 2024
sources/install/package_ad.sh Outdated Show resolved Hide resolved
@QU35T-code QU35T-code removed the waiting for additional changes Further changes are requested label Jun 4, 2024
@QU35T-code QU35T-code added the waiting for additional changes Further changes are requested label Jun 4, 2024
@QU35T-code QU35T-code removed the waiting for additional changes Further changes are requested label Jun 4, 2024
@ShutdownRepo
Copy link
Member

Re-running pipeline, it failed for some unrelated reason. Thank you @p0dalirius

@QU35T-code
Copy link
Member

@p0dalirius Last change and should be ok for merge. Can you remove the comma in the add-to-list description ? (this breaks the csv parser)

smbclient-ng is a fast and user friendly way to interact with SMB shares.

@QU35T-code QU35T-code added the waiting for additional changes Further changes are requested label Jun 6, 2024
@p0dalirius
Copy link
Contributor Author

Done

@QU35T-code QU35T-code added ready for merge in the waitlist for merge, requires preliminary steps and removed waiting for additional changes Further changes are requested under review Time to think about the need / implementation labels Jun 7, 2024
@QU35T-code QU35T-code removed the ready for merge in the waitlist for merge, requires preliminary steps label Jun 8, 2024
@ShutdownRepo ShutdownRepo merged commit b768e0c into ThePorgs:dev Jun 8, 2024
42 checks passed
@QU35T-code QU35T-code mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new tool(s) This adds one or multiple tools to Exegol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants