Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding smuggler.py #87

Merged
merged 4 commits into from
Feb 23, 2023
Merged

Adding smuggler.py #87

merged 4 commits into from
Feb 23, 2023

Conversation

fransosiche
Copy link
Contributor

Hello,

As @wlayzz suggested, I added the tool smuggler.py to Exegol (very cool project btw).

@ShutdownRepo
Copy link
Member

Nice addition! I'll let you fix the conflict and we'll merge that 👍

@ShutdownRepo ShutdownRepo added the new tool(s) This adds one or multiple tools to Exegol label Jan 26, 2023
@fransosiche
Copy link
Contributor Author

Thx, conflict fixed, should be good !

Copy link
Member

@QU35T-code QU35T-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @fransosiche,

Thank you for your participation to the Exegol project !
To be really precise, I propose some small fixes and that will be perfect I think !

sources/install.sh Outdated Show resolved Hide resolved
sources/zsh/aliases.d/smuggler Outdated Show resolved Hide resolved
sources/zsh/history.d/smuggler Outdated Show resolved Hide resolved
sources/install.sh Outdated Show resolved Hide resolved
@fransosiche
Copy link
Contributor Author

Good point @QU35T-code

I fixed it !

@ShutdownRepo
Copy link
Member

Thank you for the review @QU35T-code, and @fransosiche for this PR!
Ready to merge, putting it in waitlist because of the current works on the CI/CD pipeline

@ShutdownRepo ShutdownRepo added the ready for merge in the waitlist for merge, requires preliminary steps label Jan 27, 2023
@Dramelac
Copy link
Member

Hello @fransosiche

Sorry to repeat the process again but it's the last time!
Can you update your PR with the dev branch to resolve conflicts (this update will also merge the new CI/CD pipeline)

After that we will be able to run the test and merge your PR!

And thank you for your contribution!

@fransosiche
Copy link
Contributor Author

Hello @Dramelac,

it should be good !

@ShutdownRepo ShutdownRepo merged commit bbf4bb2 into ThePorgs:dev Feb 23, 2023
@ShutdownRepo ShutdownRepo mentioned this pull request Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new tool(s) This adds one or multiple tools to Exegol ready for merge in the waitlist for merge, requires preliminary steps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants