-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RES-1863 Add draggable map for group create #637
Open
edwh
wants to merge
18
commits into
develop
Choose a base branch
from
RES-1862_draggable_map
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
edwh
commented
Apr 11, 2023
- Add a draggable map component. This will be shared later with events (which isn't in Vue yet).
- Use this component from group create/edit.
- Allow the API call to take a lat/lng from the client if passed; otherwise we fall back to the geocoded location.
# Conflicts: # resources/js/components/GroupLocation.vue
edwh
changed the title
RES-1862 Add draggable map for group create
RES-1863 Add draggable map for group create
May 17, 2023
# Conflicts: # resources/js/components/GroupLocation.vue
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
…S-1858_mapbox_geocode # Conflicts: # app/Helpers/Geocoder.php # package-lock.json # resources/js/components/VenueAddress.vue # tests/Unit/GeocoderTest.php
# Conflicts: # app/Http/Controllers/API/GroupController.php
SonarCloud Quality Gate failed. 0 Bugs No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.