Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RES-1891 Network Coordinator can't create events on other groups they created #646

Merged
merged 1 commit into from
May 17, 2023
Merged

RES-1891 Network Coordinator can't create events on other groups they created #646

merged 1 commit into from
May 17, 2023

Conversation

edwh
Copy link
Collaborator

@edwh edwh commented May 5, 2023

The code in User::groupsInChargeOf had bad logic.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

ngm
ngm approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@ngm ngm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Removes the assumption that a network coordinator won't be a host of a group outside of their network.

@edwh edwh merged commit 7ffc777 into develop May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngm ngm ngm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edwh @ngm