Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RES-1883 Remove useful URLs feature #650

Merged
merged 3 commits into from
May 22, 2023
Merged

RES-1883 Remove useful URLs feature #650

merged 3 commits into from
May 22, 2023

Conversation

edwh
Copy link
Collaborator

@edwh edwh commented May 9, 2023

This feature was very rarely used, and has been retired. This PR removes the code and adds a migration to drop the table.

ngm
ngm requested changes May 16, 2023
View reviewed changes
Copy link
Contributor

@ngm ngm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an insignificant amount of code, for such an unused feature!

I notice that the migration is empty. I presume we just need to be dropping the device_urls table?

@edwh
Copy link
Collaborator Author

edwh commented May 17, 2023

Not an insignificant amount of code, for such an unused feature!

I notice that the migration is empty. I presume we just need to be dropping the device_urls table?

Added

@edwh edwh closed this May 17, 2023
@ngm
Copy link
Contributor

ngm commented May 17, 2023

@edwh Did you mean to close this PR?

@edwh edwh reopened this May 17, 2023
@edwh
Copy link
Collaborator Author

edwh commented May 17, 2023

@ngm No, I didn't. Re-opened so you can review the migration.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@edwh edwh merged commit 469204f into develop May 22, 2023
@ngm ngm deleted the RES-1883_remove_useful_urls branch June 19, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngm ngm ngm requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edwh @ngm