RES-1895 Allow editing of network data on events #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ork_data_on_events # Conflicts: # app/Http/Controllers/API/EventController.php # tests/Feature/Events/APIv2EventTest.php
|
SonarCloud Quality Gate failed.
|
# Conflicts: # app/Http/Controllers/PartyController.php # resources/js/components/EventAddEdit.vue # resources/js/components/EventAddEditPage.vue # resources/views/events/create.blade.php
|
Kudos, SonarCloud Quality Gate passed!
|
edwh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on RES-1885, which is not yet released to develop. The diffs will therefore look strange.
This PR applies analogous changes to #651. There are some slight changes to the use of
canApproveso that it is always passed and can be used to decide whether or not to show these fields. As previously the permission model is a bit of a guddle.There's a bit of surprise when you first see this, because you kind of expect "Add network data fields" or something. So perhaps this needs an intro text. But it's for network coordinators, who are probably not such delicate flowers as to faint when presented with this kind of thing.