New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RES-1908 country codes #665

Merged

edwh merged 9 commits into develop from RES-1908_country_codes

Aug 2, 2023

Collaborator

edwh commented Jun 21, 2023

Add the country_code field to users and groups via a migration.
Change the code to use the country_code field. I initially did this with the migration deleting the country field in the groups table to get the tests running without it, then removed that delete.
Add a scheduled hourly command to sync the country code field to country

edwh added 5 commits

June 12, 2023 18:12


          Change from storing country names in the DB to country codes.

9e644b2


          Test fixes.

2bfb55e


          Fix branch name display.

3242a38


          Add sync of country code to country field.

e0f4873


          Test tweaks.

ac3b26c

ngm approved these changes

View reviewed changes

Contributor

ngm left a comment

All looks good, just missing a reverse of the migration I think.

I'll have a bit of a smoke test through locally.

database/migrations/2023_06_12_153317_country_codes.php Outdated Show resolved Hide resolved

edwh and others added 4 commits

July 10, 2023 09:28


          Merge branch 'develop' into RES-1908_country_codes

c36e953

# Conflicts:
#	app/Http/Controllers/ExportController.php


          Review fixes

e3e7db1


          Escape group keyword

e701f74


          Use country name matching results from geocoder

b81db47

sonarqubecloud bot commented Aug 1, 2023

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
9 Code Smells

No Coverage information
4.7% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

edwh merged commit 1abc978 into develop

ngm deleted the RES-1908_country_codes branch

June 19, 2024 16:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet