RES-1910 Event chat and attendee count inconsistencies

[edwh]

Based on RES-1855 so the diffs are confusing until that is merged.

• Move the maintenance of the volunteer count and the Discourse thread into an observer, which is triggered by changes to EventsUsers. This means we don't have to rely on the calling code to remember to do it...except for deletes (see this).
• Background the actual processing this via events and listeners in the usual way
• Introduce a method into DiscourseService to remove a user from the private message thread.
• When the host of a group is added to an event, they should become a host of the event.
• Allow fetching of an event over the API if it is not yet approved. No reason not to do this, and it helps with testing.

[ngm]

Couple of questions about the logic of who is set as a host of an event when joining the event.

[ngm]

This would make network coordinators and admins hosts of the event, too, right?

I can think of cases where that's not going to match reality (e.g. me, going to an event). But, probably generally fine.

[ngm]

For the case where a host of one group attends an event by another group, this would automatically make them host of that event? I don't think that should be the case. It should only turn hosts of the event's group into hosts of the event, no?

[edwh]

The second point would also fix the first. This logic isn't well-tested in any case, so I've added a test for it to check that people are/aren't added as hosts appropriately.

[ngm]

I think the logic for setting event role needs changing, see comment.

[ngm]

I think this should just be

$eventRole = $u && Fixometer::userIsHostOfGroup($party->group, $user) ? Role::HOST : Role::RESTARTER;

as there could be admins or network coordinators who are host of the group, and should get set with $eventRole = Role::HOST, even if their overall role ($u->role) might not be Role::HOST.

[edwh]

Agreed. I've made that change.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
22 Code Smells

No Coverage information
0.0% Duplication