Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RES-1926 WordPress error emails caused by event edits #672

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

edwh
Copy link
Collaborator

@edwh edwh commented Aug 7, 2023

EditWordpressPostForEvent is looking in the data passed to the (Laravel) event for the id of the group. That isn't always present, and doesn't need to be because we have the (Restarters) event in hand and can pull the group from there.

@edwh edwh requested a review from restart-neil August 7, 2023 14:06
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@ngm ngm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted in Jira, I think this may mean that event group changes are no longer propagated, but that that's OK.

@edwh edwh merged commit 9ab7b19 into develop Aug 23, 2023
@edwh edwh changed the title RES-1926 Event handler is looking for data which doesn't get passed RES-1926 WordPress error emails caused by event edits Aug 23, 2023
@ngm ngm deleted the RES-1926_event_wordpress_failure_mails_to_admin branch June 19, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants