Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RES-1953 When a group has no events, on the Fixometer page, make it clearer how they can add data #700

Merged
merged 5 commits into from
Nov 21, 2023

Conversation

edwh
Copy link
Collaborator

@edwh edwh commented Nov 15, 2023

Convert Add Data modal to Vue:

  • Add component.
  • Pass user groups to it via FixometerPage. We don't currently have API calls to fetch this.
  • Add store call to fetch the events for the group from the new API.
  • Remove old API call which was only used in this case.

Then handle the case of no events

  • Show appropriate message
  • Change button text
  • Fix the create event page to correctly set the group as it intends to.

Also handle the case of no groups.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So long, fixometer.js!

@edwh edwh merged commit b5b722a into develop Nov 21, 2023
1 check was pending
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants