Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RES-1954 Add banner for Aviva crowdfunder #705

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

edwh
Copy link
Collaborator

@edwh edwh commented Nov 27, 2023

As subject.

@edwh edwh requested a review from restart-neil November 27, 2023 10:59
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Banner looks good - but think it needs the id of the banner changing on line 33? Currently set to biggive2023.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - didn't notice despite the comment. Changed.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@edwh edwh merged commit 781345a into develop Nov 27, 2023
3 of 4 checks passed
@ngm ngm deleted the RES-1954_aviva_crowdfunder_banner branch June 19, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants