RES-1976 Tidy up old Discourse log files #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm fine with this, but for reference I believe there is a 'days' parameter on the 'daily' log driver, which you can use to specify many days of logs to keep. |
ngm
approved these changes
Aug 8, 2024
|
I think you're right, and it would just be tech debt to do it the way I've done it. So I'll rework. |
|
ngm
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're using Monolog for Discourse API logging, which doesn't have built-in compression and deletion - see Seldaek/monolog#1202
This PR is a way of deleting old log files. It feels a bit clunky - there might be a better way to do it - but it works.