Adding Additional Tricks #76
Conversation
- Mockball - Sword Only Dark Rooms - Light World South Fake Flippers
|
I updated the version number as discussed in the other PR. Wasn't sure if you meant updating to 3.5.0 or 4.0.0, so I did this for now. Feel free to update (or tell me to update) if you'd prefer 4.0.0. |
|
4.0 is probably fine considering the amount of technically breaking updates we've done. |
src/Randomizer.SMZ3/ILogic.cs
Outdated
| @@ -55,5 +55,11 @@ public interface ILogic | |||
| public bool CanPassFireRodDarkRooms(Progression items); | |||
|
|
|||
| public bool CanParlorSpeedBoost(Progression items); | |||
|
|
|||
| public bool CanPassMockBallRoom(Progression items); | |||
There was a problem hiding this comment.
Nitpicking, but I feel like the logic shouldn't be named after the trick if it can return true when you have the trick disabled.
One solution would be to rename this to CanPerformMockball and adding || items.SpeedBooster to everything, but I think I'd prefer this to be called something sillier like CanMoveAtHighSpeeds or something more elegant.
There was a problem hiding this comment.
Hmm... I must have misunderstood your previous suggestion from one of the previous PRs, I suppose. I'll make these updates and update to 4.0.
|
|
||
| public bool CanPassSwordOnlyDarkRoom(Progression items); | ||
|
|
||
| public bool CanHyruleSouthFakeFlippers(Progression items, bool fairyChests); |
There was a problem hiding this comment.
Same as above. In this case I think it makes more sense to move items.Flippers out of this method, but if you have a better suggestion for the name to avoid that then that's fine too. I just want this to be clear at a glance when looking at some regions without having to check the definition of these methods.
| @@ -19,6 +19,15 @@ public class LogicConfig | |||
| [DisplayName("Parlor Speed Booster Break In"), Description("You're expected to be able to use the speed booster to burst through to the Terminator Room/Brinstar without morph/power bombs or screw attack"), Category("Tricks")] | |||
| public bool ParlorSpeedBooster { get; set; } | |||
|
|
|||
| [DisplayName("Mockball"), Description("You're expected to be able to be able to use to mockball to avoid having the speed booster at the entrance to Green Brinstar and Upper Norfair West"), Category("Tricks")] | |||
- Updated trick function names - Updated version to 4.0.0
|
Updates made |
Added a few simple to implement tricks