Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Experimental] Handle interruptions #98

Merged
merged 3 commits into from
Mar 27, 2022
Merged

Conversation

Vivelin
Copy link
Member

@Vivelin Vivelin commented Mar 27, 2022

Pink inspired me by sometimes tracking multiple items in rapid succession — issues commands while Tracker is still responding to the previous command. I figured it'd be fun to add a little flair by having Tracker interrupt these kinds of situations with some sass.

Considerations:

  • How many times should Tracker tolerate being interrupted before speaking up about it?
  • Should we add a timeout before speaking up again, in addition to the threshold?
    • It's not likely to happen too often. And if it does happen often, we should increase the threshold instead. But still, it's worth considering.
  • I've added Feature toggles #97 so for similar ideas in the future, we can experiment more easily and give users the ability to toggle something off.

@Vivelin Vivelin added 🔍 Tracker Issues related to item/location tracking 🎭 Tracker Personality labels Mar 27, 2022
@Vivelin Vivelin requested a review from MattEqualsCoder March 27, 2022 13:45
@Vivelin Vivelin added this to the v4.2 milestone Mar 27, 2022
@Vivelin Vivelin merged commit 1fdca4b into main Mar 27, 2022
@Vivelin Vivelin deleted the feature/handle-interruptions branch March 27, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔍 Tracker Issues related to item/location tracking 🎭 Tracker Personality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants