Instead of crashing, show a warning and return #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(and provides a warning about it) |
|
It's ok to have an empty type. I think we can just check the uri and be good. Haven't had a chance to test it though. |
cobarx
approved these changes
Feb 19, 2019
beauner69
pushed a commit
to beauner69/react-native-video
that referenced
this pull request
Oct 10, 2019
Instead of crashing, show a warning and return (rebased from commit f69231f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having an issue with iOS crashing in RCTVideo.m line 446 because sometimes my data wasn't as I thought it should be. pathForResource is nullable, yet initFileURLWithPath cannot take a null-parameter. This patch makes sure we don't get a null at all on bad input.