Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): check disableFocus when state is ready #3494

Conversation

YangJonghun
Copy link
Collaborator

Update the changelog

fix(android): check disableFocus when state is ready

Describe the changes

check disableFocus prop when state is ready (currently only works on playback toggle)

@freeboub
Copy link
Collaborator

I don't understand why you do this change ...
Audio focus and keep screen on are 2 differents features, controlled independently.
No need of this change in my point of view

@YangJonghun
Copy link
Collaborator Author

@freeboub
You're right, I was just trying to sync the behavior with this code.
I think it would be better to remove the if (!disableFocus) from the existing code, what do you think?

@freeboub
Copy link
Collaborator

@YangJonghun I agree, removing the other reference makes more sense !

@YangJonghun
Copy link
Collaborator Author

@freeboub I fixed it. thanks!

@KrzysztofMoch KrzysztofMoch merged commit 366c841 into TheWidlarzGroup:master Mar 8, 2024
3 checks passed
@YangJonghun YangJonghun deleted the fix/disable-focus-when-source-ready branch March 9, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants