-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iOS): rewrite DRM Module #4136
feat(iOS): rewrite DRM Module #4136
Conversation
@freeboub should I add someone else to reviewers ? |
Maybe @paul-rinaldi or @paulrinaldi would like to test this version ? I can review but not test on my side ... |
ios/Video/Features/DRMManager+AVContentKeySessionDelegate.swift
Outdated
Show resolved
Hide resolved
I added some small comments, but it looks like good job 👍 |
I don't have a tv with iOS on it or vision OS. I have physical iPhones and physical iPads I could test with if you would like me to but it sounds like the PR creator already did that. Sorry I could not be more helpful. |
My proposal was linked to your message on discord in fact ! |
I have tested it and it works fine also it solved buffering issues in drm videos. |
3bd5834
to
6be407d
Compare
4cb8b05
to
516335d
Compare
Looks good to me. Please build a release after merging this PR :) |
Sure I will give this PR to tests for our client and after it will do it! Thanks! |
516335d
to
59ba0fd
Compare
Waiting for the merge |
59ba0fd
to
2dedcd2
Compare
346f441
to
e41a178
Compare
ead3023
to
85a027c
Compare
Is this ready to be merged? |
Summary
I have re-implemented DRM module for Apple devices. New Implementation use
AVContentKeySession
instead of resource loader.fixes #4177 #3675 #3467
Motivation
Motivation is to fix issue with DRM Airplay and add visionOS support (in old implementation it was not possible)
Test plan
Tested on