feat: add setSource API function fix ads playback #4185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o into feat/reworkSourceStart # Conflicts: # src/Video.tsx
freeboub
requested review from
KrzysztofMoch,
seyedmostafahasani and
moskalakamil
|
@KrzysztofMoch If you want to do a first review on this PR it would be great, There is a remaining resize glitch on sample when we change video on android, I will fix that. |
OK, this is fixed ! |
This was referenced Sep 26, 2024
|
@freeboub |
seyedmostafahasani
approved these changes
Sep 28, 2024
KrzysztofMoch
requested changes
Oct 2, 2024
android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java
Outdated
Show resolved
Hide resolved
|
PR Looks Good For Me - only this ADS thing need to be fixed and we can merge |
…o into feat/reworkSourceStart
|
@KrzysztofMoch Done, thank you for the feedback ! |
KrzysztofMoch
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
feat: Add setSource API
fix(android): playback start up
Motivation
Add setSource API, linked to: #3352
fix: #3928
Changes
Add setSource command: easy on ios
On Android:
I moved management of playback stop from : ReactExoplayerViewManager.kt to ReactExoplayerView.java
I added concept of running source. I allows to avoid race conditions. during asynchronious process of startup, we are now stopping it if start has been canceled
For ads, I avoid releasing this adsLoader when the player is not destroyed.
Test plan
Sample has been patched to integrate this source change