add ipod-library support #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 31, 2018 20:23
|
@yasiryang Thanks for this submission! I'm guessing this is an iOS only feature. How do I go about testing this? I want to provide examples for each of the source types in the README, so some usage instructions would help a lot. |
cobarx
reviewed
Jun 9, 2018
ios/RCTVideo.m
Outdated
| @@ -732,7 +732,10 @@ - (void)setProgressUpdateInterval:(float)progressUpdateInterval | |||
| - (void)removePlayerLayer | |||
| { | |||
| [_playerLayer removeFromSuperlayer]; | |||
| [_playerLayer removeObserver:self forKeyPath:readyForDisplayKeyPath]; | |||
| @try{ | |||
There was a problem hiding this comment.
What's triggering this crash? I'd like to fix the issue where we remove an observer that doesn't exist rather than putting a bandaid over it with try / catch.
Couldn't figure out how this was happening, so I don't want to hide it with try/catch. Let's get it fixed instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should support ipod-library protocol for iPod library