-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify the organization of the library #222
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thealexbarney
force-pushed
the
move
branch
2 times, most recently
from
January 7, 2022 01:00
6772b73
to
c8a60ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to how LibHac started off and then evolved, there is currently a lot of clutter with how the namespaces are organized. This PR cleans things up by partially reorganizing the library's namespaces by following a couple guidelines:
LibHac
namespace contains namespaces/code that follows the same structure as Nintendo's official code. e.g. "LibHac.FsSystem`LibHac.Tools
namespace contains classes that do other things such as provide additional functionality (LikeLibHac.Tools.Fs.SwitchFs
), provide a more user-friendly API for working with things (LikeLibHac.Tools.FsSystem.NcaUtils
), etc.This PR should only contain changes that involve reorganization of the library's namespace structure. APIs of individual classes and library functionality shouldn't be changed at all.