Add support for CEF128 #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
#228
What this PR does / why we need it:
Add support for CEF128.
settings.chrome_runtimeandsettings.persist_user_preferencesare removed since CEF128 because CEF always uses Chrome runtime, meanschrome_runtimeis always true, andpersist_user_preferencesis alwaystrue.chromiumembedded/cef@a461a89#diff-447d40892c51b4ffc870cf1a28bab2ae2d411752216be4750a17193e6675b26bL244
chromiumembedded/cef@a461a89#diff-447d40892c51b4ffc870cf1a28bab2ae2d411752216be4750a17193e6675b26bL347
chromiumembedded/cef#3685
How to verify the fixed issue:
https://github.com/ThinBridge/Chronos/actions/runs/10505750334/job/29103948165