Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug on dbObject->with($objectName) #626

Closed
tuananh77 opened this issue May 30, 2017 · 1 comment
Closed

Bug on dbObject->with($objectName) #626

tuananh77 opened this issue May 30, 2017 · 1 comment

Comments

@tuananh77
Copy link

I think there is a mistake at line 386 in the function dbObject->with($objectName)
Currently
if (!property_exists ($this, 'relations') && !isset ($this->relations[$name]))
The correct conditions should be
if (!property_exists ($this, 'relations') || !isset ($this->relations[$objectName]))

Correct me if I'm wrong.
This wrapper is great, and exactly what I need. Excellent work.
Thank you.

@avbdr
Copy link
Collaborator

avbdr commented Jun 2, 2017

thanks for your finding. can you please submit a pull request with added testcase into tests/ file?

@avbdr avbdr closed this as completed in 97f20c2 Aug 6, 2017
ricwein pushed a commit to ricwein/PHP-MySQLi-Database-Class that referenced this issue Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants